pdehaan
commented
4 years ago Also randomly tried bandit, which didn't give a lot of feedback:
bandit -r *.py emails phones privaterelay
[main] INFO profile include tests: None
[main] INFO profile exclude tests: None
[main] INFO cli include tests: None
[main] INFO cli exclude tests: None
[main] INFO running on Python 3.7.4
[node_visitor] INFO Unable to find qualified name for module: manage.py
Run started:2020-04-14 16:40:05.061205
Test results:
>> Issue: [B101:assert_used] Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Severity: Low Confidence: High
Location: emails/tests/model_tests.py:18
More Info: https://bandit.readthedocs.io/en/latest/plugins/b101_assert_used.html
17 relay_address = RelayAddress.make_relay_address(self.user)
18 assert relay_address.user == self.user
19
--------------------------------------------------
>> Issue: [B101:assert_used] Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Severity: Low Confidence: High
Location: emails/tests/model_tests.py:25
More Info: https://bandit.readthedocs.io/en/latest/plugins/b101_assert_used.html
24 relay_addresses.append(RelayAddress.make_relay_address(self.user))
25 assert len(relay_addresses) == len(set(relay_addresses))
26
--------------------------------------------------
>> Issue: [B101:assert_used] Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Severity: Low Confidence: High
Location: emails/tests/model_tests.py:32
More Info: https://bandit.readthedocs.io/en/latest/plugins/b101_assert_used.html
31 deleted_count = DeletedAddress.objects.filter(address_hash=address_hash).count()
32 assert deleted_count == 1
33
--------------------------------------------------
Code scanned:
Total lines of code: 1135
Total lines skipped (#nosec): 0
Run metrics:
Total issues (by severity):
Undefined: 0.0
Low: 3.0
Medium: 0.0
High: 0.0
Total issues (by confidence):
Undefined: 0.0
Low: 0.0
Medium: 0.0
High: 3.0
Files skipped (0):
groovecoder
jwhitlock
Ref: #160
OK, I had a bit more time last night to randomly look at Python libraries, and maybe we want some combination of Black (#160) and Pylint (which I'm assuming is roughly similar to Prettier+ESLint respectively).
I managed to pip install pylint in a virtualenv and then run this command:
Where I had to do some fiddling with the .pylintrc config file to exclude a bunch of messages I wasn't ready to hear from yet (about 98% of that list was automatically generated by pylint, I only added a few gems at the top of the list):