search

mozilla / fx-private-relay

Keep your email safe from hackers and trackers. Make an email alias with 1 click, and keep your address to yourself.
https://relay.firefox.com
Other
1.46k stars 174 forks source link

FxA sends events for non-Relay users to /fxa-rp-events #1930

Open jwhitlock opened 2 years ago

jwhitlock commented 2 years ago

When FxA sends an event to /fxp-rp-events for an FxA user without a related Relay account, an error is logged:

SocialAccount.DoesNotExist: SocialAccount matching query does not exist.

Sentry:

This is causing noise in Sentry. A different logging method may make this signal more actionable:

say-yawn commented 2 years ago

Question to FxA, are they sending us pings on updates for accounts that are not users of Relay? If so, when we handle errors we should verify that the account is a real FxA user and ignore while for accounts that is not a real FxA account we log separately for abuse metrics later.

say-yawn commented 2 years ago

Collect event type and FxA id to take back to the FxA team to see if these accounts are doing anything suspicious.

jwhitlock commented 2 years ago

Other interesting /fxa-rp-events data:

jwhitlock commented 2 years ago

FxA sends us data but we don't have a token so we can't get more info about the user: https://sentry.prod.mozaws.net/operations/fx-private-relay-prod/issues/19493775

jwhitlock commented 1 year ago

Sentry has changed. New links: