Failed authentication leads to 500 error

mozilla / fx-private-relay

Keep your email safe from hackers and trackers. Make an email alias with 1 click, and keep your address to yourself.

https://relay.firefox.com

Other

1.48k stars 177 forks source link

Failed authentication leads to 500 error #2122

Open jwhitlock opened 2 years ago

jwhitlock commented 2 years ago

django-allauth URLs unused by Relay were removed in PR #2007. Some of these are used in the default error templates used by allauth:

FxA error 1:
- Team: https://sentry.prod.mozaws.net/operations/fx-private-relay-prod/issues/19505214/
- Public: https://sentry.prod.mozaws.net/share/issue/67e9b2c63c36403d914349b05db4906e/
FxA error 2:
- Team: https://sentry.prod.mozaws.net/operations/fx-private-relay-prod/issues/19505203/
- Public: https://sentry.prod.mozaws.net/share/issue/0fd2b4cf6ba844c49b91131928112044/

Overriding these template with Relay-appropriate ones should fix the issue.

jwhitlock commented 2 years ago

Another:

jwhitlock commented 2 years ago

The base template used by these errors includes links to account login. If we provide a different base template, these errors should render correctly:

https://github.com/pennersr/django-allauth/blob/master/allauth/templates/account/base.html

jwhitlock commented 1 year ago

Errors in the new Sentry:

account_login: https://sentry.io/organizations/mozilla/issues/3669039787/?project=4503976951152641
socialaccount_signup: https://sentry.io/organizations/mozilla/issues/3669169813/?project=4503976951152641

oliviamoc commented 1 year ago

Hello,

I need to unsubscribe from this and please remove me fom your maillist...

sentry-io[bot] commented 1 year ago

Sentry issue: RELAY-5

sentry-io[bot] commented 1 year ago

Sentry issue: RELAY-C