Closed rafeerahman closed 1 month ago
Your pull request is modifying functions with the following pre-existing issues:
๐ File: privaterelay/allauth.py
Function | Unhandled Issue |
---|---|
is_safe_url |
AttributeError: 'NoneType' object has no attribute 'get_response' /ac... Event Count: 3 |
Did you find this useful? React with a ๐ or ๐
Closing this PR. find_file_at_path does not return None.
This PR fixes MPP-3730.
Bug description
These URLs works, redirects to the API profile page after login:
https://dev.fxprivaterelay.nonprod.cloudops.mozgcp.net/accounts/fxa/login/?next=/api/v1/profiles/
https://stage.fxprivaterelay.nonprod.cloudops.mozgcp.net/accounts/fxa/login/?next=/api/v1/profiles/
https://relay.firefox.com/accounts/fxa/login/?next=/api/v1/profiles/
Locally, accounts/fxa/login/?next=/faq/ works. It does not work in stage/dev/prod because we use staticfiles, redirects to the dashboard instead of the FAQ and emits a Sentry error:
https://dev.fxprivaterelay.nonprod.cloudops.mozgcp.net/accounts/fxa/login/?next=/faq/
https://stage.fxprivaterelay.nonprod.cloudops.mozgcp.net/accounts/fxa/login/?next=/faq/
https://relay.firefox.com/accounts/fxa/login/?next=/faq/
Sentry Issue: RELAY-JH
Screenshot (if applicable)
How to test
push to dev server and go to https://dev.fxprivaterelay.nonprod.cloudops.mozgcp.net/accounts/fxa/login/?next=/faq/
Verify you are redirected to the faq page.
Checklist (Definition of Done)
/frontend/src/styles/tokens.scss
).