Closed jwhitlock closed 5 days ago
The screenshots help establish context for the pings really well, but a couple (non-blocking) concerns about including screenshots:
We only include screenshots for the website and not the add-on
Yep, the new detailed sections only cover the website. The add-on documentation (called an "Extension", we should revisit if we want to use that) is untouched and at the bottom of the document. I hope to tackle that next.
We will have to maintain the screenshots
A few thoughts:
This rewrites
METRICS.md
to include all the frontend code that emits Google Analytics events, as well as sample images to make it easier to refer to buttons and text.The images are minimized for size with pngquant. They are displayed at 1/3 width, and can be clicked to see the full image.
How to test:
Read the doc, see if anything sounds off. Don't feel you have to read all the details, skimming is fine.
Spot check by searching for categories, labels, etc in
frontend/src
.[x] I've added or updated relevant docs in the docs/ directory.