MPP-3827: Move non-model code out of `emails/models.py` - Githubissues

mozilla / fx-private-relay

Keep your email safe from hackers and trackers. Make an email alias with 1 click, and keep your address to yourself.

https://relay.firefox.com

Other

1.44k stars 168 forks source link

MPP-3827: Move non-model code out of `emails/models.py` #4799

Closed jwhitlock closed 1 week ago

jwhitlock commented 1 week ago

This PR moves code around, in preparation for moving Profile (and other models) from the emails app to the privaterelay app.

emails/exceptions.py - Defines the exceptions raised in the emails app
emails/validators.py - Defines the validator functions used in the emails app.
emails/models.py
- The remaining functions have moved to the top of the file, and have type hints.
- DomainAddress.make_domain_address used to take a Profile, and now takes a User.

This also involved moving tests around, and some test changes for the new interfaces.