mozilla / fx-private-relay

Keep your email safe from hackers and trackers. Make an email alias with 1 click, and keep your address to yourself.
https://relay.firefox.com
Other
1.49k stars 177 forks source link

Bump eslint-config-next from 14.2.7 to 14.2.9 #5026

Closed dependabot[bot] closed 2 months ago

dependabot[bot] commented 2 months ago

Bumps eslint-config-next from 14.2.7 to 14.2.9.

Release notes

Sourced from eslint-config-next's releases.

v14.2.9

[!NOTE]
This release is backporting bug fixes. It does not include all pending features/changes on canary.

Core Changes

  • Revert "Fix esm property def in flight loader (#66990)" (#69749)
  • Disable experimental.optimizeServer by default to fix failed server action (#69788)
  • Fix middleware fallback: false case (#69799)
  • Fix status code for /_not-found route (#64058) (#69808)
  • Fix metadata prop merging (#69807)
  • create-next-app: fix font file corruption when using import alias (#69806)

Credits

Huge thanks to @​huozhi, @​ztanner, @​ijjk, and @​lubieowoce for helping!

v14.2.8

What's Changed

[!NOTE]
This release is backporting bug fixes and minor improvements. It does not include all pending features/changes on canary.

Support esmExternals in app directory

  • Support esm externals in app router (#65041)
  • Turbopack: Allow client components from foreign code in app routes (#64751)
  • Turbopack: add support for esm externals in app dir (#64918)
  • other related PRs: #66990 #66727 #66286 #65519

Reading cookies set in middleware in components and actions

  • initialize ALS with cookies in middleware (#65008)
  • fix middleware cookie initialization (#65820)
  • ensure cookies set in middleware can be read in a server action (#67924)
  • fix: merged middleware cookies should preserve options (#67956)

Metadata and icons

  • support facebook-specific metadata (fb:app_id, fb:admins) in generateMetaData (#65713)
  • Always collect static icons for all segments (#68712)
  • Fix favicon merging with customized icons (#67982)
  • Warn metadataBase missing in standalone mode or non vercel deployment (#66296)

Parallel routes fixes

  • fix missing stylesheets when parallel routes are present (#69507)

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
jwhitlock commented 2 months ago

@dependabot rebase

jwhitlock commented 2 months ago

The latest version eslint-config-next includes @typescript-eslint/eslint-plugin, using an older version:

    "@typescript-eslint/eslint-plugin": "^5.4.2 || ^6.0.0 || 7.0.0 - 7.2.0",
    "@typescript-eslint/parser": "^5.4.2 || ^6.0.0 || 7.0.0 - 7.2.0",

https://github.com/vercel/next.js/blob/6fa8982f8eb766663fd1e11e43621e53fd8e016c/packages/eslint-config-next/package.json#L15-L16

When running npm run lint, I'd get an error:

ESLint: Plugin "@typescript-eslint" was conflicted between ".eslintrc.js" and ".eslintrc.js » plugin:@typescript-eslint/recommended » ./configs/base".

This FAQ entry suggested running:

npm list @typescript-eslint/eslint-plugin @typescript-eslint/parser

which showed the conflicting versions:

└─┬ frontend@0.1.0 -> ./frontend
  ├─┬ @typescript-eslint/eslint-plugin@8.4.0
  │ └── @typescript-eslint/parser@8.4.0 deduped
  ├── @typescript-eslint/parser@8.4.0
  └─┬ eslint-config-next@14.2.9
    ├─┬ @typescript-eslint/eslint-plugin@7.2.0
    │ └── @typescript-eslint/parser@7.2.0 deduped
    └── @typescript-eslint/parser@7.2.0

The fix I'm trying is:

  1. npm uninstall @typescript-eslint/eslint-plugin @typescript-eslint/parser to remove 8.4.0 of both
  2. npm fix to include a semvar update
  3. npm prune to remove from my node_modules
  4. Update .eslint.rc to settings suggested by Next.js TypeScript docs.

I'm not a fan of downgrading @typescript-eslint/eslint-plugin @typescript-eslint/parser, but it doesn't include downgrading typescript itself, so maybe this is OK and will make it easier to update next.js when version 15 is ready.

Update: I do see this message in CI, which I don't see locally.

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.5.0

YOUR TYPESCRIPT VERSION: 5.5.4
groovecoder commented 2 months ago

Thanks for working thru this.

I was able to reproduce this error locally:

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.5.0

YOUR TYPESCRIPT VERSION: 5.5.4

Please only submit bug reports when using the officially supported version.

By doing rm -rf frontend/node_modules.