mozilla / fx-private-relay

Keep your email safe from hackers and trackers. Make an email alias with 1 click, and keep your address to yourself.
https://relay.firefox.com
Other
1.49k stars 177 forks source link

MPP-3119: complaint notification disables mask #5045

Closed groovecoder closed 1 month ago

groovecoder commented 2 months ago

Disable mask on complaint notification

See https://mozilla-hub.atlassian.net/browse/MPP-3119 for more context.

When a user (or their email provider) marks a Relay email as spam, we receive a complaint notification. To prevent further spam from reaching the user (causing more complaints), we want to disable the email mask that forwarded the spam email, and notify the user.

Screenshot (if applicable)

image

How to test

This will be hard to test until it's on a server with fully operational AWS SES. When it is:

  1. Sign up for Relay with an FXA that has a gmail, yahoo, or outlook primary email address
  2. In the django admin site, activate the new disable_mask_on_complaint flag for the user
  3. Create an email mask
  4. Send an email to that mask
  5. In the final destination mailbox, mark that email as spam
    • Note: It's unclear if all email providers send these complaint notifications, but gmail, yahoo, outlook, and other popular providers seem to do so.
    • Note 2: It's also unclear how long it takes for AWS to process complaint notifications and send them to Relay
  6. At some point, Relay should receive the complaint notification
    • [ ] Verify the mask is disabled
    • [ ] Verify the user received an email notification that their mask was disabled

Checklist (Definition of Done)

groovecoder commented 1 month ago

I made https://github.com/mozilla/fx-private-relay/pull/5045/commits/75e4d85aaa7c1ff2f2d4a3ded5f1fb05b5aed4aa to address https://github.com/mozilla/fx-private-relay/pull/5045#discussion_r1774118156.

Need to dig into https://github.com/mozilla/fx-private-relay/pull/5045#discussion_r1774112661.