search

mozilla / fxa-auth-db-mysql

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
12 stars 26 forks source link

Don't run eslint in npm test #257

Closed philbooth closed 7 years ago

philbooth commented 7 years ago

This repo runs eslint when you do npm t. That's really annoying if you're trying to debug why some tests are failing locally and you insert a bunch of console.log to debug. Now the tests don't even run because the linter helpfully reports Unexpected console statement then craps out.

We can still incorporate the linter as part of npm run test-travis for CI.

shane-tomlinson commented 7 years ago

We can still incorporate the linter as part of npm run test-travis for CI.

It can also be done as a pre-push git hook to get quicker feedback. The content server does it that way and it's saved me quite a few times.

philbooth commented 7 years ago

It can also be done as a pre-push git hook to get quicker feedback. The content server does it that way and it's saved me quite a few times.

That annoys me too tbh. I should be able to push a WIP branch without eslint getting all uppity about it and making me use --no-verify. I push more WIP branches than I do non-WIP branches, so the default behaviour should stay out of my way. I'm very happy to run eslint manually when I want it to run locally.

philbooth commented 7 years ago

Essentially, I don't want to work in a Nanny State. Let me ride my bike without stabilizers until it is time to open a pull request.