Pulled into a single PR because they're all related and it didn't seem like too great a burden for a single reviewer. But I'm happy to break them apart if you'd rather review them independently.
In 82170eb, I add a lint for FOREIGN KEY constraints in CREATE TABLE statements.
In daf2677, I add a lint for email arguments of stored procedures, checking that they're declared with the expected CHARACTER SET.
In 6065fe8, I refactor the ROW_COUNT checking stuff, so that it fits in with the pattern that has evolved with the preceding lints.
In edf0bb4, I ignore a bunch of existing stored procedures that fail the new lints.
In 3aeca8e, I develop the ignore format so that it can include both procedure and table names.
Fixes #434. Fixes #440.
Pulled into a single PR because they're all related and it didn't seem like too great a burden for a single reviewer. But I'm happy to break them apart if you'd rather review them independently.
In 82170eb, I add a lint for
FOREIGN KEYconstraints inCREATE TABLEstatements.In daf2677, I add a lint for email arguments of stored procedures, checking that they're declared with the expected
CHARACTER SET.In 6065fe8, I refactor the
ROW_COUNTchecking stuff, so that it fits in with the pattern that has evolved with the preceding lints.In edf0bb4, I ignore a bunch of existing stored procedures that fail the new lints.
In 3aeca8e, I develop the ignore format so that it can include both procedure and table names.
@mozilla/fxa-devs r?