search

mozilla / fxa-auth-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
399 stars 121 forks source link

Add option to disable requirement of config.events to be set in production #2904

Closed jbrunink closed 5 years ago

jbrunink commented 5 years ago

Folks,

First of all, quite new to all this collaboration bits and bobs. I'm trying to run my own Mozilla Services. For my simple setup I don't see the need to have config.events to be set. When I change the NODE_ENV variable to production it requires me though.

According to the friendly folks in #fxa it's made deliberately hard to disable the events system to guard against accidentally deploying this into production without it being properly set. It was reasonable to create a configuration flag to disable this requirement which is by default set to true.

So hereby.

Best regards,

Jurgen Brunink

rfk commented 5 years ago

Thanks @jbrunink, this looks like exactly what I had in mind!

First of all, quite new to all this collaboration bits and bobs.

Well, doubly thanks for contributing then! In case you didn't see it, I just want to make sure you read the contributing guidelines here:

https://github.com/mozilla/fxa-auth-server/blob/master/CONTRIBUTING.md

And in particular the part about contributions being licensed under the Mozilla Public License.

jbrunink commented 5 years ago

Perfectly fine with that. Thank you!

On Wed, Feb 6, 2019, 04:09 Ryan Kelly notifications@github.com wrote:

Thanks @jbrunink https://github.com/jbrunink, this looks like exactly what I had in mind!

First of all, quite new to all this collaboration bits and bobs.

Well, doubly thanks for contributing then! In case you didn't see it, I just want to make sure you read the contributing guidelines here:

https://github.com/mozilla/fxa-auth-server/blob/master/CONTRIBUTING.md

And in particular the part about contributions being licensed under the Mozilla Public License.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla/fxa-auth-server/pull/2904#issuecomment-460886713, or mute the thread https://github.com/notifications/unsubscribe-auth/ABE-Dng3nkd8C7pdJEyul9o-qN5ZjAmMks5vKkdygaJpZM4ajErB .

rfk commented 5 years ago

Thanks again!