search

mozilla / fxa-auth-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
399 stars 121 forks source link

Include `service` as data when sending `verified` events to Basket #2915

Closed shane-tomlinson closed 5 years ago

shane-tomlinson commented 5 years ago

Initial conversation in https://github.com/mozmeao/basket/issues/131

The Mozmeao team would like to create custom onboarding journeys for different services, but we don't provide sufficient information for them to do so.

When we send verified events, we do not send along which service the user was signing up for.

I propose we send the service info along with the verified event that's broadcast to reliers.

@pmac, for OAuth reliers service is the relier's client_id. We could convert that to something more human readable like we do for metrics, not sure what's best for your uses.

blocks https://github.com/mozmeao/basket/issues/132

Longer term we could probably also send login events for all services rather than just Sync to enable Mozmeao to send helpful info when a user with an existing account signs in to a new service.

cc @pmac, @LaurenNiolet

pmac commented 5 years ago

I propose we send the service info along with the verified event that's broadcast to reliers.

@pmac, for OAuth reliers service is the relier's client_id. We could convert that to something more human readable like we do for metrics, not sure what's best for your uses.

That all sounds perfect to me.

Longer term we could probably also send login events for all services rather than just Sync to enable Mozmeao to send helpful info when a user with an existing account signs in to a new service.

That would also be good. All we'll need is information on what to expect in the queue message JSON schema and we'll figure out where to put the new info on our side.

davismtl commented 5 years ago

In support of this fix, this will also be needed since IoT Things is experimenting with FxA. They don't want Things users to get any Firefox onboarding emails. They'll likely want to personalize their onboarding experience.

LaurenNiolet commented 5 years ago

It's alive!! Services are coming through and at a reasonable mix (most sync, the rest are scattered among the other services).