Incorrect parameters passed to DB in bin/profile_server_messaging.js

mozilla / fxa-auth-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa

Mozilla Public License 2.0

399 stars 121 forks source link

Incorrect parameters passed to DB in bin/profile_server_messaging.js #2916

Closed shane-tomlinson closed 5 years ago

shane-tomlinson commented 5 years ago

This file: https://github.com/mozilla/fxa-auth-server/blob/master/bin/profile_server_messaging.js

It passes incorrect parameters when opening the DB which makes me believe it's no longer used. I don't see any tests for it either.

If it's unused, let's remove it.

cc @jrgm, @eoger

shane-tomlinson commented 5 years ago

As @jrgm and @philbooth point out, we should have some tests for this.

jrgm commented 5 years ago

Just to note what was said in triage meeting: It is used and is running in production and does appear to be working and not showing errors, but maybe just because it never calls the db object's methods in a way that would fail.