search

mozilla / fxa-auth-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
399 stars 121 forks source link

fix(metrics): reinstate entrypoint to the metrics context schema #2929

Closed philbooth closed 5 years ago

philbooth commented 5 years ago

Related to #2917.

Adds entrypoint as an optional property of the metrics context payload. Also adds some validation for entrypoint and the UTM params. That duplicates validation in the content server so we probably want to refactor both to fxa-shared at some point (I'll open a separate issue for that).

@mozilla/fxa-devs r?

philbooth commented 5 years ago

That duplicates validation in the content server so we probably want to refactor both to fxa-shared at some point (I'll open a separate issue for that).

Ref: mozilla/fxa-shared#59

philbooth commented 5 years ago

Fwiw, I decided to rebase this against train-131 so we can land it a train ahead of the equivalent content-server changes and not worry about any rollbacks or whatever.