search

mozilla / fxa-auth-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
399 stars 121 forks source link

fix(db): Stop using deprecated 'sessionWithDevice' db route. #2934

Closed rfk closed 5 years ago

rfk commented 5 years ago

The database now always returns device information when getting a sessionToken, so we don't need to use a special route for it. I think this code was just left over from our cleanup of the old "sessionWithDevice" route.

philbooth commented 5 years ago

After this has shipped we can also physically remove /sessionToken/:id/device from the db server too, right?

rfk commented 5 years ago

After this has shipped we can also physically remove /sessionToken/:id/device from the db server too, right?

Yep, doing that over in https://github.com/mozilla/fxa-auth-db-mysql/pull/483 as an opportunistic cleanup (although I could be convinced to make it a separate PR if that's preferred)

shane-tomlinson commented 5 years ago

Yep, doing that over in mozilla/fxa-auth-db-mysql#483 as an opportunistic cleanup (although I could be convinced to make it a separate PR if that's preferred)

It might be easier to extract that change so that it's not dependent on the DB migration.

rfk commented 5 years ago

k, sure thing: https://github.com/mozilla/fxa-auth-db-mysql/pull/484