Depends on mozilla/fxa-shared#61. Related to #2939.
Before starting on the verification reminder stuff, I wanted to update this repo to use the fxa-shared Redis code while that refactoring was still fresh in mind. This was made much easier by @shane-tomlinson's sterling work to harmonise the log interfaces in #2950.
I pondered for a while about what kind of test coverage was most appropriate here, since all of the tests that were previously in this repo have now moved to fxa-shared. Part of me was inclined to just go with some unit-level tests that mock out the fxa-shared dependency. But because the remote tests were already in tree and they're the truest test we have that everything really works, I opted to just keep those instead. It does leave us in the slightly odd situation where we've got duplicate test cases in this repo and fxa-shared, but belt and braces are the new skinny jeans. All the cool kids wear both.
Depends on mozilla/fxa-shared#61. Related to #2939.
Before starting on the verification reminder stuff, I wanted to update this repo to use the
fxa-sharedRedis code while that refactoring was still fresh in mind. This was made much easier by @shane-tomlinson's sterling work to harmonise the log interfaces in #2950.I pondered for a while about what kind of test coverage was most appropriate here, since all of the tests that were previously in this repo have now moved to
fxa-shared. Part of me was inclined to just go with some unit-level tests that mock out thefxa-shareddependency. But because the remote tests were already in tree and they're the truest test we have that everything really works, I opted to just keep those instead. It does leave us in the slightly odd situation where we've got duplicate test cases in this repo andfxa-shared, but belt and braces are the new skinny jeans. All the cool kids wear both.@mozilla/fxa-devs r?