search

mozilla / fxa-auth-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
399 stars 121 forks source link

Remove support for node 8, support 10+ #2958

Closed shane-tomlinson closed 5 years ago

shane-tomlinson commented 5 years ago

We still support node 8 but our Docker images are now built using node 10. Let's drop support for node 8 and remove node-scrypt from the devDependencies list.

farhan787 commented 5 years ago

remove node-scrypt from the devDependencies list.

@shane-tomlinson if I'm not wrong node-scrypt is not there is devDependencies.

shane-tomlinson commented 5 years ago

@shane-tomlinson if I'm not wrong node-scrypt is not there is devDependencies.

You are right, I meant optionalDependencies.

farhan787 commented 5 years ago

@shane-tomlinson ok, but now node-scrypt is used nowhere in the project.

shane-tomlinson commented 5 years ago

It is used here and should be removed. It looks like we should also be able to remove this if statement, deleting from if, up to and including the first else.

farhan787 commented 5 years ago

@shane-tomlinson I thought it's literally node-scrypt, btw thanks for correcting me.