search

mozilla / fxa-auth-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
399 stars 121 forks source link

Replace the `redis.watch.conflict` 500 errors with 409 Conflict #2966

Closed philbooth closed 5 years ago

philbooth commented 5 years ago

It's annoying when these show up in Sentry because they're not actionable and already well-understood. When I wrote the code I thought 500 was the semantically appropriate status to return, but maybe 409 Conflict would be fine too. Then we'd stop getting badgered in Sentry.

shane-tomlinson commented 5 years ago

but maybe 409 Conflict would be fine too

👍 this seems reasonable.

farhan787 commented 5 years ago

@philbooth may I fix this ?

philbooth commented 5 years ago

Sorry @farhan787, I already opened a PR.

farhan787 commented 5 years ago

@philbooth no problem, just saw you amazing work there!