mozilla / fxa-auth-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
399 stars 121 forks source link

fix(scripts): ignore bouncing accounts in verification reminders #3010

Open philbooth opened 5 years ago

philbooth commented 5 years ago

Small tweak for the verification reminders script, if the mailer fails with a bounce error then just delete the reminder records and ignore that account.

It turns out it's quite hard to force a bounce error in local testing. I tried with a non-existent domain and a non-existent account at a valid domain, but the email service succeeded with both. So I'm going to mark this as WIP and try again tomorrow. We can still cut the train in the meantime, I'll make a point release if I get it to fail.

shane-tomlinson commented 5 years ago

This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo.