search

mozilla / fxa-content-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
163 stars 120 forks source link

Copy/pasting links fails when mail client inserts whitespace #1174

Closed fmarier closed 10 years ago

fmarier commented 10 years ago

So our links look like https://accounts.firefox.com/v1/verify_email?uid=deadbeef&code=101cafe

The links are so long (in the plaintext version of the email) that when I copied it in my browser, it ended up like https://accounts.firefox.com/v1/verify_email?uid=dead beef&code=101 cafe (notice the spaces between dead and beef as well as between 101 and cafe).

Stripping out whitespace inside the hex fields we receive should solve this problem.

(moved from https://github.com/mozilla/fxa-auth-server/issues/722)

fmarier commented 10 years ago

WIP at https://github.com/fmarier/fxa-content-server/tree/issue1174

fmarier commented 10 years ago

Fix in #1175.

pdehaan commented 10 years ago

@fmarier What browser/client were you using? I wasn't able to repro the bonus spaces issue w/ zimbra or my gmail with the plaintext emails.

fmarier commented 10 years ago

@pdehaan mutt in a terminal.

I expect all text-based mail clients will have the same issues though because you have to break the line somehow when you can't scroll horizontally.

ckarlof commented 10 years ago

@pdehaan you need to try this:

200px-neckbeards

this might work too: time-machines-through-er-time-20100325065957774

vladikoff commented 10 years ago

Verified using Lynx

vladikoff commented 10 years ago

Fixed in https://github.com/mozilla/fxa-content-server/commit/1d1919ac5b427ea8568ae9c04bd8380334db93b4