search

mozilla / fxa-content-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
163 stars 120 forks source link

fix(blank email): error message for blank email query parameter fixed #7046

Closed farhan787 closed 5 years ago

farhan787 commented 5 years ago

fixes #6880

farhan787 commented 5 years ago

@shane-tomlinson please review it!

farhan787 commented 5 years ago

@shane-tomlinson I learned from my mistake, though I knew that this was specific to emails but I wanted to fix this quickly but from now I'll make sure that I work as much as generic as I can in my upcoming work. I also request you to review my pending PRs so that if there are any changes to make then I can work on them.

shane-tomlinson commented 5 years ago

@farhan787 - It is strange to me that the '' unit test still passes. '' should be moved to be part of the testValidQueryParam list and I'd expect it to fail where it is.

Also, can you essentially copy this functional test to a new one just below that specifies an empty string for the email?

farhan787 commented 5 years ago

@shane-tomlinson I've made the changes, hope you like it!

farhan787 commented 5 years ago

Thank you very much for this!

@shane-tomlinson it's my pleasure :-)

SorinaFlorean commented 5 years ago

Verified as fixed on stage - Train 133, following the steps from #6880.