mozilla / fxa-content-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
163 stars 120 forks source link

style(vpassword focused): verify password focused when switching from sign in to sign up #7054

Closed farhan787 closed 5 years ago

farhan787 commented 5 years ago

fixes #6040

farhan787 commented 5 years ago

@shane-tomlinson is it good now ?

vbudhram commented 5 years ago

@shane-tomlinson I noticed the linked bug is closed, is this issue still applicable?

shane-tomlinson commented 5 years ago

@shane-tomlinson I noticed the linked bug is closed, is this issue still applicable?

As I said above, I view it a bit as busywork since we are deprecating this flow, but if it fixes the problem then we can merge.

farhan787 commented 5 years ago

@shane-tomlinson I want to ask you that if a user is redirected to sign up page with email and password auto-filled up then the vpassword field should be focused instead of age, and the user should retype his/her password to confirm the password. So, how come we want to focus the age field ?

shane-tomlinson commented 5 years ago

So, how come we want to focus the age field ?

We want the vpassword field focused if there is no vpassword pre-fileld. If there is a vpassword prefilled, then we want age focused.

farhan787 commented 5 years ago

If there is a vpassword prefilled, then we want age focused.

@shane-tomlinson that's what I want to ask, in which case we have vpassword prefilled ?

shane-tomlinson commented 5 years ago

@shane-tomlinson that's what I want to ask, in which case we have vpassword prefilled ?

Ahha! Here's a video to show you:

vpassword-prefilled

Here's the flow:

  1. Open https://127.0.0.1:3030?action=email
  2. Enter a new username
  3. On the password page, enter both a password and vpassword
  4. Click "Mistyped email?"
  5. On the "enter your email" screen, re-submit the original email.
  6. Both password and vpassword are prefilled.
farhan787 commented 5 years ago

Ahha! Here's a video to show you:

vpassword-prefilled

@shane-tomlinson I noticed in this video too, the autofocus isn't working good because it should focus on age field as password and vpassword are pre-filled and that's why I fixed it too. Please review it :-)