search

mozilla / fxa-content-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
163 stars 120 forks source link

Add client icon for Send in device list #7062

Closed ryanfeeley closed 5 years ago

ryanfeeley commented 5 years ago

I noticed that there is no device icon for Send in the client list. Here is one! Send_Glyph.svg.zip

ryanfeeley commented 5 years ago

I ran it through https://jakearchibald.github.io/svgomg/

AlbionaHoti commented 5 years ago

Hi, @ryanfeeley I am an outreachy applicant and would like to work on this issue :)

lmorchard commented 5 years ago

@AlbionaHoti feel free to take this one on! Do you have a good idea of what needs to be done here? Feel free to ask!

AlbionaHoti commented 5 years ago

@lmorchard Thank you!

As I can see - there is the Devices & Apps button on Settings page - When it's open it shows a list of devices - it helped me the clients.js file in settings folder and the clients.js in testing where it was mentioned the "device list" | Is the idea to add the icon somewhere there or is it something else?

lmorchard commented 5 years ago

@AlbionaHoti Yeah, looks like in that devices list is where this image should go.

I haven't worked on that area of the app yet, but I see this list of services and images in app/styles/modules/_settings.scss associated with service names for .client-oAuthApp. You should be able to add the image and add a style there to match on data-name='Firefox Send'.

lmorchard commented 5 years ago

(oops, hit the wrong button and didn't mean to close)