style(modal): spinner and modal size

mozilla / fxa-content-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa

Mozilla Public License 2.0

163 stars 120 forks source link

style(modal): spinner and modal size #7071

Open shreya99oak opened 5 years ago

shreya99oak commented 5 years ago

fixes #6268 Sorry for the delay! Pls. review @shane-tomlinson

farhan787 commented 5 years ago

@shreya99oak IMHO you should read https://github.com/mozilla/fxa-content-server/blob/master/CONTRIBUTING.md#git-commit-guidelines because the commit message should contain style(modal)...

shreya99oak commented 5 years ago

Thanks @shreya99oak for this. I want to get @ryanfeeley's feedback on which spinner he means. The update seems unexpectedly large to me:

The other thing is that we should use the same spinner when opening the Camera link.

Ok cool, yes even I had felt odd about the spinner size, but I assumed this is what he meant

shane-tomlinson commented 5 years ago

This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo.