search

mozilla / fxa-content-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
163 stars 120 forks source link

fix(style): scale down larger customized qr-image for totp #7073

Closed l-hedgehog closed 5 years ago

l-hedgehog commented 5 years ago

In FxA China stack, we set totp.serviceName to "accounts.firefox.com.cn" in fxa-auth-server, as a result, our QR Code for totp is 276x276px, larger than the hard coded 228x228px.

I considered making fxa-auth-server return the size with the data uri or making this configurable in fxa-content-server, but ended up deciding it's simpler to just scale down the customized QR Code.

l-hedgehog commented 5 years ago

Thanks @shane-tomlinson !