search

mozilla / fxa-content-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
163 stars 120 forks source link

feat(totp): Add loading indicator for session status verification #7081

Closed karansapolia closed 5 years ago

karansapolia commented 5 years ago

Show a loading indicator when 'Enable' is clicked in Two-step authentication settings panel and session is being verified. Remove the earlier used unverified panel during verification. Consequently remove the jank caused due to unverified panel when section is opened.

fixes: #6877

@vbudhram would request your review :smiley:

karansapolia commented 5 years ago

@vbudhram any pointers on how to resolve the failing tests?

karansapolia commented 5 years ago

For reference, this is the how the loading indicator functions now. totp

karansapolia commented 5 years ago

Sure thing! Thank you. This will be my first commit here. :smiley:

vbudhram commented 5 years ago

Hey @karansapolia can you rebase your patch from master? That should fix the errors.

karansapolia commented 5 years ago

Done. :smiley: All checks passing now @vbudhram