search

mozilla / fxa-content-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
163 stars 120 forks source link

fix(totp): replace recovery codes keyboard accessibility #7090

Open karansapolia opened 5 years ago

karansapolia commented 5 years ago

Make 'Replace recovery codes' link keyboard accessible. Add ability for tab indexing through link and pressing enter to click on link.

fixes: #6593 @ryanfeeley Would request you to review.

karansapolia commented 5 years ago

For reference, with keyboard accessibility working: keyboardAccessible

shane-tomlinson commented 5 years ago

@vbudhram - could you review this?

karansapolia commented 5 years ago

@karansapolia Thanks for the PR, I think a better solution in this scenario is to use a button instead of a link. You will need to style the button to look like a link though. By doing this you can remove the href tag.

Oh alright, let me do that and update the PR.

karansapolia commented 5 years ago

@vbudhram have made the requested changes. review please.

karansapolia commented 5 years ago

@vbudhram review please.

shane-tomlinson commented 5 years ago

This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo.