search

mozilla / fxa-content-server

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
163 stars 120 forks source link

Add errno 121 to oauth-errors.js #7095

Closed shane-tomlinson closed 5 years ago

shane-tomlinson commented 5 years ago

Over in mozilla/fxa-auth-server#2969, @rfk added errno 121 to the oauth errors, "Invalid grant_type". We'll need to add that to oauth-errors.js.

hritvi commented 5 years ago

Just a idea, shouldn't we write a script to automatically add any errors which are added in the auth-server. Or is there any other thing that is stopping us from doing that?

shane-tomlinson commented 5 years ago

We have a bug about sharing errors across repos, but I can't find it. It's mentioned in this one.

philbooth commented 5 years ago

When we move to a monorepo we won't need a script, the definitions can just be included in both places.