Brittle functional test causes false positives

[zaach]

This particular functional test in tests/functional/settings.js is a serious offender: sign in, try to change password with an incorrect old password.

There are a couple of other functional tests that use wait (in reset_password.js and confirm.js) that might deserve some attention, too.

[vladikoff]

// brittle, but some processing time.
        .wait(2000)

        .elementByCssSelector('.error').isDisplayed()
          .then(function (isDisplayed) {
            assert.isTrue(isDisplayed);
          })
        .end()

this can probably use

.waitForElementByCssSelector

I'll PR something tomorrow if this isn't updated.

[zaach]

@vladikoff Maybe, I think that's not being used because the element is already in the DOM but not displayed. I'm looking now.

[vladikoff]

waitForVisibleByCssSelector

might also work, I'll have to check. Via https://github.com/admc/wd/blob/v0.2.2/doc/jsonwire-full-mapping.md

[zaach]

Yep, I'm trying it out now.

[pdehaan]

wait(Number.POSITIVE_INFINITY)?