search

mozilla / fxa-email-service

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
6 stars 6 forks source link

feat(bounces): use timestamps from ses instead of the current time #231

Closed philbooth closed 6 years ago

philbooth commented 6 years ago

Fixes #205.

SES provides a UTC-based timestamp for bounce and complaint events but the auth server opted to ignore it. I'm not sure that was the optimal decision because messages might linger on a queue (either ours or the provider's) for a length of time before we process it. Given that we already trust SES et al to deliver sane notifications, it doesn't seem too great a stretch to also trust the timestamp on those notifications.

@mozilla/fxa-devs r?

vladikoff commented 6 years ago 
   Compiling fxa_email_service v1.124.0 (/home/travis/build/mozilla/fxa-email-service)
warning: variant is never constructed: `Configuration`
   --> src/db/core/mod.rs:111:5
    |
111 |     Configuration
    |     ^^^^^^^^^^^^^
    |
    = note: #[warn(dead_code)] on by default
    Finished dev [unoptimized + debuginfo] target(s) in 6m 55s
philbooth commented 6 years ago

Yeah, that dead code warning is stuff that was added in preparation for #185. I'm hoping to implement the rest of it tomorrow or Friday, then the warning will go away.