search

mozilla / fxa-email-service

DEPRECATED - Migrated to https://github.com/mozilla/fxa
Mozilla Public License 2.0
6 stars 6 forks source link

Two differences in SMTP/MIME sent via email-service vs. auth-server, and encoding issue in Thunderbird #239

Closed jrgm closed 5 years ago

jrgm commented 5 years ago

Not saying there's necessarily a bug here, but I inspected the email sent via email-service vs. one sent by auth-server and note these differences.

  1. Via auth server has these two headers that email-service does not:

    Content-Language: en
Sender: Firefox Accounts <accounts@firefox.com>

  2. Via auth server, the HTML part is sent as:

Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

while with the email service it is:

Content-Transfer-Encoding: base64
Content-Type: text/html
jrgm commented 5 years ago

Actually, visually inspecting the HTML content in Thunderbird, with fxa-email-service, I see:

Confirm you’ve received this email and we’ll help you install and sync Firefox 
on all your devices starting with:
jrgm commented 5 years ago

In gmail, via email-service, that text in the HTML appears correctly. So, just a tbird bug?

jrgm commented 5 years ago

If it wasn't clear, the above was referring to the altered apostrope in you’ve and we’ll.

jrgm commented 5 years ago

Content-Type: text/html; charset=utf-8

I'm pretty sure that the issue with the apostrophe is because email-service content lacks charset=utf-8.

jrgm commented 5 years ago

/me smacks stupid English-centric brain

Yeah. UTF-8. Disabling in prod now. Apologies.

jrgm commented 5 years ago

What users see is a function of how auto-detect of encodings is configured in their email viewer. With browsers and webmail, it usually corrects. My email viewer was not set to auto-detect, so it was a mess in, e.g., Japanese.

jrgm commented 5 years ago

This was fixed in https://github.com/mozilla/fxa-email-service/pull/240. Closing.