mozilla / fxa-features

meta-repo for managing feature planning lifecycle in Firefox Accounts
2 stars 3 forks source link

Send a push notification to all devices on profile change #118

Closed shane-tomlinson closed 7 years ago

shane-tomlinson commented 7 years ago

If a user has multiple connected devices and changes their profile info on one device, there is significant lag before that info is updated on the other devices. This lag time could be greatly reduced by sending a push notification to all devices.

Ref https://github.com/mozilla/fxa-content-server/issues/4755

rfk commented 7 years ago

Just some high-level notes here while I think of them...

So to make this push message we could either:

The first would be slightly more reliable, at the cost of tighter coupling, as I don't think the profile-server currently knows anything about the auth-server.

eoger commented 7 years ago

I'd be happy to work on this once we decide on which solution we would like to go with. (I'm leaning a bit towards the first solution, which feels a bit less hacky too me).

rfk commented 7 years ago

(I'm leaning a bit towards the first solution, which feels a bit less hacky too me).

Sounds fine to me. The profile-server can't directly call the /devices/notify endpoint, since it doesn't hold a sessionToken. We could instead have it write events into an SQS queue, and have the auth-server pull them off and send them out to the devices.

vladikoff commented 7 years ago

@eoger can this be closed?

eoger commented 7 years ago

Kill it 🔫