search

mozilla / fxa-local-dev

An easy way to contribute to Firefox Accounts
28 stars 47 forks source link

chore(server): #94 Added memcached service #100

Closed deeptibaghel closed 6 years ago

deeptibaghel commented 6 years ago

Added memcached.

deeptibaghel commented 6 years ago

@vladikoff , have added memcached, tested on mac only as yet. Pl. let me know if it looks ok.

vladikoff commented 6 years ago

@deeptibaghel almost there! just need a few fixes, also could you please rename the commit to Adding memcached service. This is not adding any docker services yet. We can merge this with just memcached for now 👍

vladikoff commented 6 years ago

@deeptibaghel there is also a test file here: https://github.com/mozilla/fxa-local-dev/blob/master/test/curl.sh

Add a new check to make sure memcache is running in there, I suggest running it locally first so you don't wait on GitHub/Travis CI to report results, it will take some time. Let me know if you have questions!

deeptibaghel commented 6 years ago

Thanks @vladikoff , made changes and tested :) . Also squashed the commits.

deeptibaghel commented 6 years ago

r? @vladikoff

vladikoff commented 6 years ago

👍 Thank you!!