search

mozilla / fxa-local-dev

An easy way to contribute to Firefox Accounts
28 stars 47 forks source link

#101 Create a script that alerts devs #109

Closed deeptibaghel closed 6 years ago

deeptibaghel commented 6 years ago

@vladikoff , i started with checking memcached. It is failing if we install from source in mac. t/lru-maintainer.t (Wstat: 512 Tests: 226 Failed: 2)

do we need to proceed like this only ?

vladikoff commented 6 years ago

@deeptibaghel you should just detect platform and if it is MAC then it should just run brew install memcached

vladikoff commented 6 years ago

@deeptibaghel for now if NOT MAC (os x), we can just log a message and say "memcached missing"

vladikoff commented 6 years ago

@deeptibaghel which reminds me, didn't we want to just move memcached to a docker container, and then we just need to make sure docker is present

deeptibaghel commented 6 years ago

@vladikoff i have moved memcached to docker and then checking only docker.

vladikoff commented 6 years ago

@deeptibaghel awesome thanks!

shane-tomlinson commented 6 years ago

This is awesome!