feat(config): add nvmrc file for easier nvm use

mozilla / fxa-local-dev

An easy way to contribute to Firefox Accounts

28 stars 47 forks source link

feat(config): add nvmrc file for easier nvm use #88

Closed udaraweerasinghege closed 7 years ago

udaraweerasinghege commented 7 years ago

Reference: https://github.com/creationix/nvm#nvmrc Less overhead for figuring out which node version to use. Can run nvm use instead, or if setup on user's shell it can be automagically be made to run nvm use

vladikoff commented 7 years ago

This fails in CI with:

HEAD is now at 0a95e77... v0.33.2
N/A: version "4.8 -> N/A" is not yet installed.
You need to run "nvm install 4.8" to install it before using it.

udaraweerasinghege commented 7 years ago

@vladikoff Ahh 4.8 isn't installed on travis. Since it specifies node 4.5 on travis. Is it meant to be using 4.8, since there was a recent pr to update docs to ask users to install 4.8+.

vladikoff commented 7 years ago

@udaraweerasinghege let's update that travis file to use 4.8 as well 👍