mozilla / fxa-oauth-server

OAuth server for Firefox Accounts
49 stars 40 forks source link

Revert "fix(config): mark config sentryDsn and mysql password sensitive (#511) #512

Closed jrgm closed 6 years ago

jrgm commented 6 years ago

This reverts commit d98fbcde7376a9bf8b310d44d0937a47c0b7ff1f.

So, the new strict validation is not happy if FXA_OPENID_KEY is set via the environment. Complains about:

Error: configuration param 'openid.key.kty' not declared in the schema
configuration param 'openid.key.n' not declared in the schema
configuration param 'openid.key.e' not declared in the schema
configuration param 'openid.key.d' not declared in the schema
configuration param 'openid.key.p' not declared in the schema
configuration param 'openid.key.q' not declared in the schema
configuration param 'openid.key.dp' not declared in the schema
configuration param 'openid.key.dq' not declared in the schema
configuration param 'openid.key.qi' not declared in the schema
configuration param 'openid.key.kid' not declared in the schema
configuration param 'openid.key.fxa-createdAt' not declared in the schema

Ugh. Do we have to declare all of those, with defaults.

Anyways, reverting to fix nightly.dev

GitCop commented 6 years ago

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

Guidelines are available at https://github.com/mozilla/fxa-oauth-server


This message was auto-generated by https://gitcop.com