search

mozilla / fxa-oauth-server

OAuth server for Firefox Accounts
48 stars 40 forks source link

fix(changelog): Fixes #524 automated changelog is borked #542

Closed deeptibaghel closed 6 years ago

deeptibaghel commented 6 years ago

r? @vladikoff , I think we need to add "chore" to template.

vladikoff commented 6 years ago

@deeptibaghel this looks good but needs rebase, the train version 110 got its change log in there.

I think we need to add "chore" to template.

what do you mean? If you mean chore appears in the changelog right now, it is fine 👍

deeptibaghel commented 6 years ago

If you mean chore appears in the changelog right now,

I mean it is not here , so it shows in lowercase "chore" : https://github.com/vladikoff/fxa-conventional-changelog/blob/72ac737fcb66a96f48ed16b8dc31e0a750a7f572/index.js#L29

vladikoff commented 6 years ago

I mean it is not here , so it shows in lowercase "chore" :

Ah yes, no worries!