mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)
https://mozilla.github.io/ecosystem-platform/
Mozilla Public License 2.0
601 stars 210 forks source link

[Subplat][email] VAT isn’t updated after card change #11881

Closed data-sync-user closed 2 years ago

data-sync-user commented 2 years ago

FxA version:

Preconditions:

Steps to reproduce:

Go to Manage Subscriptions page for the account from preconditions;

Change the Credit Card with another one from EU but where the VAT is different i.e Ireland;

Wait for the payment confirmation mail;

Verify the displayed VAT from receipt and invoice;

Expected result:

Actual result:

Notes

[https://taxfoundation.org/value-added-tax-2022-vat-rates-in-europe/|https://taxfoundation.org/value-added-tax-2022-vat-rates-in-europe/|smart-link]

┆Issue is synchronized with this Jira Bug ┆Attachments: VAT issue.png

data-sync-user commented 2 years ago

➤ Barry Chen commented:

Benjamin Bangert you know more about the tax rates than anyone, please add a comment you know offhand how to fix this. Thanks!

data-sync-user commented 2 years ago

➤ Benjamin Bangert commented:

The VAT is added as a tax_rate to the chosen subscription. Currently we only update this if the subscription is changed I believe, in this case its just a card change. To fix this, we’d need to update our payment method / card webhook responder to determine if the current country matches the proper tax rate on the users subscriptions, then update the subscriptions to use the correct tax rate object.

data-sync-user commented 2 years ago

➤ Maria Berlinger commented:

Hello,

This is verified as fixed in Train 1.229.1, VAT is updated accordingly after card change.