search

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)
https://mozilla.github.io/ecosystem-platform/
Mozilla Public License 2.0
597 stars 210 forks source link

No graphic on on the "Approval now required" card at the end of the firefox.com/pair flow, #16080

Closed dholbert closed 8 months ago

dholbert commented 11 months ago

Description

In the QR-code-based https://firefox.com/pair flow, every single card has a colorful graphic, except for one -- the "Approval now required" card.

Steps to reproduce

(These are the exact same STR as #16079 -- this issue is about the same UI, but I'm just calling attention to a different problem in this issue.)

  1. In Firefox on Android, go to the Settings (from the 3-dot menu) and tap the Sync section at the top
  2. Tap "Ready to Scan" to open a QR-code-scanner.
  3. On your desktop Firefox (where you've set up with Firefox Sync), visit https://firefox.com/pair and click "Get Started"
  4. Scan the QR code.
  5. Click through the steps on your computer, until you get to the "Approval now required" card.

Expected result

Consistent look between that card and the rest of the cards in the flow. The card should have some sort of graphic (maybe representing "check your other device"), since all the other cards have a graphic.

Actual result

No graphic on this card. As a result, it looks a little spartan/lifeless, and loses some of the enthusiasm of the previous cards in the flow.

Environment

My desktop environment (where I'm seeing the card) is Firefox 121.0a1 (2023-11-13) on Ubuntu 22.04

Screenshot of the card in question (same screenshot as in #16079): Screenshot from 2023-11-14 21-57-36

Here's a screenshot the previous card, for comparison (I'm pretty sure all of the other cards in the flow look similar to this one with a nice graphic): Screenshot from 2023-11-14 21-57-30

┆Issue is synchronized with this Jira Task

dholbert commented 11 months ago

CC @vpomerleau who might be interested, as it looks like she's been working on this flow in https://github.com/mozilla/fxa/commit/e490811f9ce3ddb80c223e0294e94b17455f37b2 at least.

(It looks like the commit fixed the text-size issue but didn't add an image, which was the other thing that the associated Jira ticket https://mozilla-hub.atlassian.net/browse/FXA-8585 was focused on and is also what I happened to independently file this issue on here.)

clouserw commented 8 months ago

Thanks for filing but this is not on our roadmap to fix at this point.