mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)
https://mozilla.github.io/ecosystem-platform/
Mozilla Public License 2.0
589 stars 212 forks source link

fix(sync): Do not send fxaLogin on login submit when next page is 2FA #17103

Closed LZoog closed 2 months ago

LZoog commented 2 months ago

Because:

This commit:

fixes FXA-9837


To test this, create an account and add 2FA, then launch fxa-dev-launcher and go through the flow in Backbone and observe behavior. Then go through the flow again with React and ensure parity.

Also please double check going through this without TOTP to ensure no regression (which I did test). Might be good also to check the flow that goes through signin_token_code (I did not test) but Vijay is working on an intermittent issue in that flow.