bug(settings): Provide correct value for service when verifying 2fa - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

589 stars 212 forks source link

bug(settings): Provide correct value for service when verifying 2fa #17104

Closed dschom closed 2 months ago

dschom commented 2 months ago

Because

We noticed that gql queries in inline_totp_setup were failing
The value for service wasn't passing validation
The service name was being passed instead of the service id

This pull request

Passes the service identifier (aka the RPs client id) in for the service value.
Uses the integration's 'getService' function to determine this value

Issue that this pull request solves

Closes: FXA-9807

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Note, the branch name is wrong. This is issue FXA-9807