refactor(functional-tests): consolidate email waiting and increase timeout - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

580 stars 210 forks source link

refactor(functional-tests): consolidate email waiting and increase timeout #17114

Closed Trinaa closed 1 month ago

Trinaa commented 1 month ago

Because

we hypothesis that the cause of intermittence in functional tests may be due to uncleared emails and inadequate wait times

This pull request

consolidates waiting for emails to the EmailClient
decouples the EmailClient from POMS
increases the default timeout from 15 to 45 seconds

Issue that this pull request solves

Closes: # FXA-9851

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

We expect to see a drop in the number of 'retries' in the Nightly monitoring after this change (see FxA Functional Test Suite Metrics)

Trinaa commented 1 month ago

Credit to @vbudhram who originally had the idea to consolidate to the email client I think and to @vpomerleau who made the hypothesis that emails timing out could be the cause of intermittent test failure.