fix(login): remove webchannel login when at signin token code load - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

580 stars 210 forks source link

fix(login): remove webchannel login when at signin token code load #17117

Closed vbudhram closed 1 month ago

vbudhram commented 1 month ago

Because

We were having intermitant issues when logging in using the React signin and Sync

This pull request

Adds an await to the fxaLogin message so that the browser has a chance to process it completely
Updates our functional and unit tests to correctly await

Issue that this pull request solves

Closes: https://mozilla-hub.atlassian.net/browse/FXA-9836

Checklist

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.