Many many functional tests were failing when signInRoutes was set to fullProdRollout
This pull request
Updates page object model names from signinReact to signin and signupReact to signup, and update the locators to works for both backbone or react
Replace use of login POM (that included a mix of signin, signup and other pages) with signin and signup for most tests (did not update the backbone Signup tests that are skipped)
Fix an error handling issue in the SigninRecoveryCodes react page
Issue that this pull request solves
Closes: #FXA-9519
Checklist
Put an x in the boxes that apply
[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Tests should work for:
showReactApp.signInRoutes set to true or false
(can be updated locally in packages/fxa-content-server/server/config/local.json)
if set to true, tests may run with backbone but any tests with this config as a skip condition will not run)
if set to false, tests will run through backbone and tests marked for react only will be skipped
signInRoutes fullProdRollout set to either true or false
Applying these changes will require a restart of the content-server (yarn pm2 restart content)
I filed a few follow up issues for investigation (noted in test fixme comments), and skipped a couple of other tests with a note to turn on with full prod rollout of React Signin.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-9519
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Tests should work for:
showReactApp.signInRoutesset to true or false (can be updated locally inpackages/fxa-content-server/server/config/local.json)fullProdRolloutset to either true or falseApplying these changes will require a restart of the content-server (
yarn pm2 restart content)I filed a few follow up issues for investigation (noted in test fixme comments), and skipped a couple of other tests with a note to turn on with full prod rollout of React Signin.