fix(emails): Dont use `session.isSessionVerified` in modal since it causes re-render - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

580 stars 210 forks source link

fix(emails): Dont use `session.isSessionVerified` in modal since it causes re-render #17123

Closed vbudhram closed 1 month ago

vbudhram commented 1 month ago

Because

Calling session.isSessionVerified updates the apollo cache of session info, which I think causes a render of the component

This pull request

Removes that check and uses the current value session.verified to send email

Issue that this pull request solves

Closes: https://mozilla-hub.atlassian.net/browse/FXA-9835

Checklist

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

I tried removing the depencies on the useEffect hook, which in theory should make the component render once, it didn't :/

vbudhram commented 1 month ago

Filed https://mozilla-hub.atlassian.net/browse/FXA-9866 to update this.