refactor(payments-stripe, auth): Update Coupon API endpoint - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

590 stars 210 forks source link

refactor(payments-stripe, auth): Update Coupon API endpoint #17124

Closed xlisachan closed 3 months ago

xlisachan commented 3 months ago

This pull request

moves applyPromotionCodeToSubscription from StripeService to PromotionCodeManager, updates respective files, as well as endpoint description.

Reference:

No updates to the API endpoint are necessary as updating discounts does not incur prorations or generate an invoice on its own. The new discounts are applied the next time the subscription creates an invoice. https://docs.stripe.com/billing/subscriptions/coupons#update-a-subscription

Issue that this pull request solves

Closes: FXA-9789

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.

xlisachan commented 3 months ago

Failing Unit Test in CI will be resolved with fix in #17083