bug(settings): Fix unnecessary bounce to signin page

[dschom]

Because

• When 2FA is required, and user did not have 2FA enabled yet, they would get bounced to the sign in page

This pull request

• Allows isSessionVerified to settle before redirecting
• Allows totpStatus to settle before redirecting
• Puts redirect logic in separate useEffect to consolidate redirect logic
• Removes that catch block that was using an undefined error state to control user flow
• Cleans up tests:
  • Made mocks accessible
  • Made sure implementations were defined in setMocks
  • Use mockReturnValue where appropriate
  • Make sure waitFor is used as needed

Issue that this pull request solves

Closes: FXA-9848

Checklist

Put an x in the boxes that apply

• [x] My commit is GPG signed.
• [x] If applicable, I have modified or added tests which pass locally.
• [ ] I have added necessary documentation (if appropriate).
• [ ] I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

The issue here was that the code did allow the call that checked for totpStatus to settle. As a result, the code would createTotp when it did not need to. An error would ensue, and the catch block surrounding createTotp would redirect the user back to the signin page needlessly.

In addition to test updates, I've manually validated with the following steps:

• Crate new account without totp
• Go to 123Done and click login require 2FA
• Enable on react experiment and reload page
• Enter email
• Enter password
• Observe 2FA setup without rebounce
• Complete 2FA flow as expected
• Rerun login requiring 2FA and observe 2FA prompt without bounce to sign in page

[LZoog]

@dschom Looks like you are missing a few dependencies in that useEffect. Code changes look fine though, I'll circle back and test locally in the morning and r+. Thanks!

[dschom]

@LZoog Thanks for testing. I've added those dependencies.

[vpomerleau]

I ran through the flow locally, can confirm I don't see a bounce back to cached signin after signing in with password 🎉

I was initially confused by the mention of signup in the PR description, so tried out that flow too. Seeing a similar bounce back there where after signup: there's a redirect to signin before proceeding to inline_totp_setup. Not the end of the world, but maybe we can file a follow up?

[dschom]

I ran through the flow locally, can confirm I don't see a bounce back to cached signin after signing in with password 🎉

I was initially confused by the mention of signup in the PR description, so tried out that flow too.

Ah, the title should say sign in.. Sorry about that. I'll file a follow up for the sign up case as well.