fix(metrics): Add Google and Apple signin telemetry

jonalmeida commented 3 months ago

This doesn't seem like the best way for landing these metrics. I believe we should be using glean extras to add the provider to be either google or apple, but I've been struggling to get the EventProperties type checking to add a new property.

Open question:

should I add the fxa-settings equivalent in this patch too?
is the test coverage sufficient?

This pull request

Adds google_oauth_email_first_start and apple_oauth_login_start.

Issue that this pull request solves

Closes: FXA-9809, FXA-9808

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[x] I have added necessary documentation (if appropriate).
[x] I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

jonalmeida commented 3 months ago

@jonalmeida I haven't ran this locally, but looksl like you have some backbone unit tests failing.

You should be able to see at http://127.0.0.1:3030/tests/index.html

Oops, I committed the wrong test update.

jonalmeida commented 3 months ago

This test failure seems unrelated:

❌ tests/subscription-tests/coupons-ui-tests/couponForeverDiscount.spec.ts: subscribe with credit card and use coupon
Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

Locator: getByRole('heading', { name: 'Subscription confirmation' })
Expected: visible
Received: hidden
Call log:
  - expect.toBeVisible with timeout 5000ms
  - waiting for getByRole('heading', { name: 'Subscription confirmation' })

    at /home/circleci/project/********/functional-tests/tests/subscription-tests/coupons-ui-tests/couponForeverDiscount.spec.ts:93:63
Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

mozilla / fxa