bug(settings): Force multiple tabs to logout of settings. - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

580 stars 210 forks source link

bug(settings): Force multiple tabs to logout of settings. #17143

Closed dschom closed 1 month ago

dschom commented 1 month ago

Because

When two tabs are open, logging out of one tab, would not impact the second tab
Some level interaction would still be possible in the second tab.

This pull request

Makes sure that after logging out of one tab, another active tab will also log out
Issue that this pull request solves

Closes: FXA-9760

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[ ] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

To test do the following:

Log in
Right click on tab, select 'duplicate tab'
In this tab log out
Go back to previous tab
Observe that on activation that tab also logs out

dschom commented 1 month ago

Note, that tests are passing, but there's an issue copying the final test report. So merging anyway! :rocket:

vpomerleau commented 1 month ago

Also tested and really really like the solution 🙌 Thanks @dschom !!