fix(functional-tests): subscription coupon tests failing on stage

Trinaa commented 3 months ago

Because

on the stage environment applying coupons fails with the error message 'An error occured processing the code. Please try again.' indicating that we've hit a rate limit. Since adding fixmes improvements restricting the number of retries and updating tests to use auto-awaiting asserts have been implemented.

This pull request

removes the fixmes to see if rate limiting is still an issue

Issue that this pull request solves

Closes: # FXA-9689

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Trinaa commented 3 months ago

After some discussion on Slack, we concluded that rate limiting is the cause of these test failures and that other improvements we've made these last months may mitigate the problem. We'd like to try removing the fixme annotations to see how the tests perform before adding back the signin. Note, signing in may have an impact on the level of rate limiting (rate limits per user/email vs rate limits per IP).

ashrivastava-qa commented 3 months ago

@Trinaa is there a timeline agreed upon for observation for this test behavior? I will keep an eye out too for it.

Trinaa commented 3 months ago

@ashrivastava-qa no firm timeline so to speak, these tests are always under observation. We discussed the action plan with these tests in the 2024/06/27 engineering meeting (see notes)

mozilla / fxa